Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor logic/render bug in version 0.7.4. #22

Closed
MihaelN opened this issue Jun 23, 2020 · 2 comments
Closed

Minor logic/render bug in version 0.7.4. #22

MihaelN opened this issue Jun 23, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@MihaelN
Copy link

MihaelN commented Jun 23, 2020

Minor bug in version 0.7.4.

Steps to reproduce:
If there are no hardcoded values, after the last separator in the Design Token tab "0" is rendered. I am assuming it renders the length of 0 when no hardcoded values can be found.

I am referring to line 60 in node_modules storybook-design-tokens/dist/component/Panel.js

storybook-design-token/src/components/Panel.tsx

Line 80 in fc491d9

{this.props.hardCodedValues.length && (

@11joselu 11joselu mentioned this issue Jun 25, 2020
Merged
@11joselu
Copy link

I see that bug too.

My bad with my MR at #20

@Sqrrl Sqrrl added the bug Something isn't working label Jun 26, 2020
@Sqrrl
Copy link
Collaborator

Sqrrl commented Jun 26, 2020

Thank you both. Published as v0.7.5

@Sqrrl Sqrrl closed this as completed Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Sqrrl @11joselu @MihaelN