-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide value with SvgToken presenter #36
Comments
Hey. I'm not sure I get your point. Could you elaborate on your issue with the SVG presenter? What makes displaying the svg value less clear? How does it affect other token types? |
@Sqrrl sorry for getting back to you so late. Showing the raw svg value in the presenter (see image) has in many cases little value. It could be useful to have a way to hide (or not render) the value column when rendering svg files and display the name and rendered svg |
I implemented a PoC and I can open a PR to discuss this further |
Sure, sounds good. |
@Sqrrl sorry missed the notification, see the related PR as a starting point to implement this feature |
svg object value is of very little use in this context and it makes usage much more cumbersome and less clear
Maybe it would be possible to add a
hideValue
attribute to theToken
object and render thevalue
attribute based on that?By setting it when parsing svg object would make it transparent and will not affect other token types
The text was updated successfully, but these errors were encountered: