Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide value with SvgToken presenter #36

Closed
yakky opened this issue Feb 7, 2021 · 5 comments · Fixed by #65
Closed

Hide value with SvgToken presenter #36

yakky opened this issue Feb 7, 2021 · 5 comments · Fixed by #65

Comments

@yakky
Copy link
Contributor

yakky commented Feb 7, 2021

svg object value is of very little use in this context and it makes usage much more cumbersome and less clear

Maybe it would be possible to add a hideValue attribute to the Token object and render the value attribute based on that?

By setting it when parsing svg object would make it transparent and will not affect other token types

@Sqrrl
Copy link
Collaborator

Sqrrl commented Feb 8, 2021

Hey. I'm not sure I get your point. Could you elaborate on your issue with the SVG presenter? What makes displaying the svg value less clear? How does it affect other token types?

@yakky
Copy link
Contributor Author

yakky commented Aug 17, 2021

@Sqrrl sorry for getting back to you so late.

Showing the raw svg value in the presenter (see image) has in many cases little value.
image

It could be useful to have a way to hide (or not render) the value column when rendering svg files and display the name and rendered svg

@yakky
Copy link
Contributor Author

yakky commented Aug 18, 2021

I implemented a PoC and I can open a PR to discuss this further

@Sqrrl
Copy link
Collaborator

Sqrrl commented Aug 20, 2021

Sure, sounds good.

@yakky
Copy link
Contributor Author

yakky commented Oct 23, 2021

@Sqrrl sorry missed the notification, see the related PR as a starting point to implement this feature

@Sqrrl Sqrrl closed this as completed in #65 Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants