Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkmarks Could Be Improved #23

Closed
phoney opened this issue Nov 10, 2016 · 4 comments
Closed

Checkmarks Could Be Improved #23

phoney opened this issue Nov 10, 2016 · 4 comments

Comments

@phoney
Copy link

phoney commented Nov 10, 2016

Couple suggestions for the checkboxes. Currently the checkboxes are invisible when not checked and even when checked they don't really look like checkboxes.

What I suggest is to configure the buttons as toggle buttons. You'll need two images, one for the checked appearance and the other for the unchecked appearance. Set the checked image for the selected state and the unchecked image for the normal state. Add an action method for touchupinside and button.selected = !button.selected. When the selected state is set the checkmark image will appear.

If you felt like it you can easily make a UIButton subclass with that behavior built in and just use that when you're building the checkmark button. This is probably best.

@pushchris
Copy link
Contributor

Thanks for the suggestion, I will add it to the queue of improvements. I would suggest not using images but rather doing it all through views. This way it is resolution independent. If you would like to contribute, feel free to fork and submit a pull request.

@phoney
Copy link
Author

phoney commented Nov 13, 2016

Perhaps unicode characters would work. There are Ballot box with check and Ballot Box characters that might work. There are a few other checkmark characters but I'm not sure what would indicate the unchecked state. This could conceivably be configurable.

I may well do this. It isn't hard. The toggle buttons would also work as part of the radio button implementation.

Is the queue of improvements public? I'm mainly interested in having a working Acroforms implementation.

@pushchris
Copy link
Contributor

Unicode could work as well. I posted a page in the wiki with the current road map. Looking to add a few more UI components to the reader on whole, then move towards actually properly implementing annotations and form editing. Currently everything is burned on top of the PDF which while functional, is not really ideal.

@phoney
Copy link
Author

phoney commented Nov 29, 2016

I'll close this issue since you accepted my pull request.

@phoney phoney closed this as completed Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants