Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two files for Ukrainian language #737

Closed
pironim opened this issue Dec 11, 2013 · 4 comments
Closed

Two files for Ukrainian language #737

pironim opened this issue Dec 11, 2013 · 4 comments
Milestone

Comments

@pironim
Copy link

pironim commented Dec 11, 2013

It's not an real issue but there two files for the same language in locales folder bootstrap-datepicker.ua.js and bootstrap-datepicker.uk.js - for the same language. ua or ukr is correct abbreviation. uk is sounds like United Kingdom. Like for me one file can be deleted.

@eternicode
Copy link
Contributor

United Kingdom would actually be "British English" en-GB, I think, but there are no significant differences from the builtin en to justify a separate locale file ;)

I'd be happy to merge these two Ukrainian files, but there are some subtle differences between them:

  • days translation for "Thursday": ua -> "Четверг", uk -> "Четвер"
  • a few monthsShort differences:
    • "Apr": ua -> "Квт", uk -> "Кві"
    • "May": ua -> "Трв", uk -> "Тра"
    • "Dec": ua -> "Грд", uk -> "Гру"

Can you tell me which translations are most accurate (or if they're equally valid)?

@pironim
Copy link
Author

pironim commented Dec 16, 2013

Both translations is correct - there is no strict rules to abbreviate month/week. "Четвер"(uk file) is correct name for "Thursday". So I think you can delete "ua" file and rename "uk" to "ua". 'UA' is correct shortcut - Ukraine have domain name .ua - http://en.wikipedia.org/wiki/.ua

@pironim
Copy link
Author

pironim commented Dec 16, 2013

So I can create PR to do this changes

@eternicode
Copy link
Contributor

Both translations is correct - there is no strict rules to abbreviate month/week.

Fair enough, but it's less a matter of "official translations" and more a matter of "what a Ukrainian would expect to see on their calendar", if you know what I mean.

I can do the merge (I'd rather take the best of both files than just delete one), I just want to make sure I do it right 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants