Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date toggles instead of selecting #813

Closed
greggoodman opened this issue Feb 5, 2014 · 5 comments
Closed

Date toggles instead of selecting #813

greggoodman opened this issue Feb 5, 2014 · 5 comments
Milestone

Comments

@greggoodman
Copy link

Currently the behavior is each time you select a date on the calendar it toggles to be selected or unselected. Either there should be an option not to have it toggle and only always select or this is a bug and should be fixed.

The usability issue is I type in a date, and the calendar jumps to the date and highlights it and then the user clicks that day to close the calendar and the date disappears.

@jiromm
Copy link

jiromm commented Feb 7, 2014

You need to comment line 2021 in source file

this.dates.remove(ix);

@eternicode eternicode added this to the 1.3.1 milestone Feb 15, 2014
@danifornells
Copy link

I've detected the same issue, i think that it should be an option.
The correct line number in source to comment as jiromm says is 1021 instead 2021. His solution solves the conflict. Thanks ;)

@fverry
Copy link

fverry commented Jul 7, 2014

Great workaround ! This thread took me some time to find, maybe you could mention it in the docs.

@tropicaldev
Copy link

toggle makes sense only if there is more than one date selected (multiple dates)...if tere is only one date should not toggle

fix should be

if(this.dates.length>1){
this.dates.remove(ix);
}

@acrobat acrobat modified the milestones: 1.3.2, 1.4.0 Dec 15, 2014
@acrobat
Copy link
Member

acrobat commented Dec 26, 2014

Fixed in #843

@acrobat acrobat closed this as completed Dec 26, 2014
@acrobat acrobat mentioned this issue Dec 26, 2014
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants