Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cached file and cached local storage are used every time a build occurs #12

Closed
lauslim12 opened this issue Oct 21, 2020 · 0 comments · Fixed by #13
Closed

Cached file and cached local storage are used every time a build occurs #12

lauslim12 opened this issue Oct 21, 2020 · 0 comments · Fixed by #13

Comments

@lauslim12
Copy link
Contributor

lauslim12 commented Oct 21, 2020

There is an issue that I noticed that some people are still stuck on the Venti banner unless they perform a hard reset or cleared their cache.

My solution is to clear the local storage every time a new build occurs, and instead of using main.js in the index.html file, I propose that we use HTMLWebpackPlugin to call main.js?<hash>.

With this, I believe that every time a new build occurs, people will not have to perform a hard reset again (we're basically fooling the browser into thinking that we have a new build).

I am currently working on it, will make a PR as soon as I am done testing this.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant