Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTTPS for all search bindings #352

Closed
mathstuf opened this issue Feb 16, 2017 · 4 comments
Closed

Use HTTPS for all search bindings #352

mathstuf opened this issue Feb 16, 2017 · 4 comments

Comments

@mathstuf
Copy link
Member

Currently, the default configuration ships with non-HTTPS URLs for search shortcuts. All searches that support HTTPS should be converted to use them.

@xelxebar
Copy link

I'm guessing that you want the example config to use https everywhere?

diff --git a/examples/config/config b/examples/config/config
index 088c0f41..575e76d9 100644
--- a/examples/config/config
+++ b/examples/config/config
@@ -319,7 +319,7 @@ set history_disable_easter_egg 1
 @cbind  ddg<DuckDuckGo:>_      = uri https://duckduckgo.com/?q=\@-encodeURIComponent(%r)-\@
 # These bindings should be entered as simply \wiki but due to escaping
 # happening in multiple stages it needs to be written like this
-@cbind  \\\\awiki<Archwiki:>_  = uri http://wiki.archlinux.org/index.php/Special:Search?search=\@-encodeURIComponent(%r)-\@&go=Go
+@cbind  \\\\awiki<Archwiki:>_  = uri https://wiki.archlinux.org/index.php/Special:Search?search=\@-encodeURIComponent(%r)-\@&go=Go
 @cbind  \\\\wiki<Wikipedia:>_  = uri https://secure.wikimedia.org/wikipedia/en/w/index.php?fulltext=Search&title=Special%3ASearch&search=\@-encodeURIComponent(%r)-\@
 
 # Handy binds
@@ -347,7 +347,7 @@ set history_disable_easter_egg 1
 @bind   <Ctrl>i  = @set_mode insert
 
 # Hard-bound bookmarks
-@cbind  gh  = uri http://www.uzbl.org
+@cbind  gh  = uri https://www.uzbl.org
 
 # New window binds
 @cbind  gw  = event REQ_NEW_WINDOW
@@ -485,8 +485,8 @@ set preset event PRESET_TABS
 # === Context menu items =====================================================
 
 # Default context menu
-menu add link Google "uri http://google.com"
-menu add link "Go Home" "uri http://uzbl.org"
+menu add link Google "uri https://google.com"
+menu add link "Go Home" "uri https://uzbl.org"
 menu add_separator separator_1
 menu add link "Quit uzbl" exit
 

@mathstuf
Copy link
Member Author

Yes, that'd be good. Please open a PR :) .

@xelxebar
Copy link

Done.

@mathstuf
Copy link
Member Author

mathstuf commented Sep 1, 2017

Fixed in #390.

@mathstuf mathstuf closed this as completed Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants