-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two mails in Inbox instead of one (2.2.1) #28
Comments
Estimate 2 hours |
we can not reproduce this situation. Maybe there was an error in the content that is now away. |
Hi Christian: please reassign this to me once #51 has been fixed, and then I can test for the two-email problem on 2.2.1 again. |
ok. Assigned now to you. Please test now again the email problem on 2.2.1. |
This situation is because of corrupt content after importing it with the importer. It is not because of wrong .json files. These are ok. Because this is wasting time for searching each time on such corrupt content situations (we had this situation already two or three times), we decided to change the importer to a simple concept like this:
|
that is still open. If you do a second import it still creates two mails! |
can not reproduce it locally any more at this time. But importer needs still a bit of code changes. |
Title of page 2.2.1 is "Chapter 2/5: Back home" |
@christian-bernet if and when this gets fixed, please let me know so I can version bump and redeploy livesintransit.org... |
Hi Christian: great, thanks for the update. @lfeine could you please test this when you have time? Best, Martin |
@christian-bernet are the changes related to this issue all in master branches? If so, this issue can be closed, as changes will go into next deployment. |
@interrogator We did not change anything this week. |
I'm not sure the previous messages mean that this still needs testing, but it doesn't show up to me anymore. Unfortunately, when replying to the formerly duplicated E-Mail, the reply button appears to not do anything (no state changes, no loading bar). The mail is still sent however, and appears when swapping back from another mail or closing and opening the mail window. The error that appears in the console after pressing the reply button is: |
There is an auto page transition when you reply to that mail which will fail, if you are not on page 2.2.1. @martindusinberre Does that work for you? |
@christian-bernet I had a look at this and I think it's a problem in the backend, right, not in the JSON files that I have. If so, then yes, please fix. The idea is that you shouldn't be able to transition from 2.2.1 to 2.2.2 unless you answer the email 2.2.1/mail1.json |
Bug for mail reply fixed: d3ff4ad Please let me know, if it is now ok for you like this. |
We will have again a look at this tomorrow and see if we can fix the problem with the circle relationship for pagetransition on page 2.2.1 |
Many thanks, Christian. I'm not sure why there's a particular problem here, as it should be a similar functionality as on 2.2.8, where you can only transition to 2.2.9 if you answer the previously received email (2.1.6). Here's it's always functioned fine, so I'm a bit surprised if the transition from 2.2.1 to 2.2.2, dependent on answering 2.2.1/mail1, doesn't work. Or have I misunderstood? Anyway, let me know if it's faster to talk by phone about this tomorrow--I'm around all day after about 9am. |
Hi @martindusinberre for this kind of situations where user should be transitioned automatically when replies to mail, you have to change "pageTransition.json" file like below: With this change button will stay invisible for the user and circle relationship (@christian-bernet mentioned) won't be problem Pages where you have page transitions that are only unlocked (without auto-transition) when user reply to specific mail you can leave like it is |
On 2.2.1, mail1.json generates two emails in the Inbox. It should only be one.
The text was updated successfully, but these errors were encountered: