Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need help? #1

Closed
m1guelpf opened this issue Feb 20, 2017 · 14 comments
Closed

Need help? #1

m1guelpf opened this issue Feb 20, 2017 · 14 comments
Labels

Comments

@m1guelpf
Copy link

Do you need any help with the project?

@uziiuzair
Copy link
Owner

Hey @m1guelpf,
I'm currently documenting how this project is supposed to work. I will definitely love any contribution you could make.

Currently, I'm working on a way to receive the POST data and add it to the database. You could check out the code in calls.php

@m1guelpf
Copy link
Author

@uziiuzair Have you through on moving to a php framework? I mean, normal php code is a bit...

@uziiuzair
Copy link
Owner

@m1guelpf definitely considered it. And I'm thinking about moving to one. I'm thinking Laravel. Do you have any suggestions?

@m1guelpf
Copy link
Author

I am very familiar with Laravel, so if you need help, I'd love to!

@Scrumplex
Copy link

And I would be in for frontend design.

@uziiuzair
Copy link
Owner

@Scrumplex that sounds good to me :) Give me a day or two to move (port) this to Laravel so that we can all start contributing to the project. I'll hit you guys up once I have it ready on laravel :)

@owenvoke
Copy link
Contributor

owenvoke commented Feb 27, 2017

I'd love to help too 😛 Looks pretty cool so far. 😄

P.S. The code uses a different table to the SQL file. Also, please don't use non-hashed passwords...

mysqli_query($connection, "select * from users where password='$password' AND username='$username'");

@uziiuzair
Copy link
Owner

@pxgamer Hey! This is actually the first project that I did from scratch 😆 The non-hashed password was something I was only for testing purpose. I was supposed to fix that before pushing it here 😛 Anyway, working on moving this to Laravel! Can't wait to work on this with all of you!! Super excited!!!

@uziiuzair
Copy link
Owner

Hey everyone! I decided it would be better if we stay on the same custom platform. Somehow I believe adding a framework (although the better choice) might make it a little bloated. What do you guys say?

@owenvoke
Copy link
Contributor

@uziiuzair to be honest I agree. Laravel is a little bit over the top for something relatively small 😃 But it's your choice.

@uziiuzair
Copy link
Owner

@pxgamer Exactly what I thought. Although using Laravel might help us in the long run. But I believe we can do better without a framework. I'm working on the Read Me right now 😃 I'll add some documentation shortly.

I have created a Slack page is you guys are interested on communicating there.

@owenvoke
Copy link
Contributor

@uziiuzair Joined 😄

@m1guelpf
Copy link
Author

@uziiuzair Joined!
If you aren't moving to a framework, at least you should consider refractoring to OOP...

@owenvoke
Copy link
Contributor

@m1guelpf agreed, procedural isn't too great. :smile Should consider going PSR compliant too. :)

Repository owner locked and limited conversation to collaborators Apr 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants