Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve conflict with narray #45

Merged
merged 1 commit into from
Feb 9, 2016
Merged

Resolve conflict with narray #45

merged 1 commit into from
Feb 9, 2016

Conversation

lokeshh
Copy link
Member

@lokeshh lokeshh commented Feb 8, 2016

Fixes #27

@v0dro Not sure but is this what you meant?

@v0dro
Copy link
Member

v0dro commented Feb 8, 2016

Why is the build failing? Can you investigate? Your fix seems fine.

It's failing only for ruby 2.3

@lokeshh
Copy link
Member Author

lokeshh commented Feb 9, 2016

Seems like they removed obsolete Prime.new in Ruby 2.3 (see here).

I will look into this.

@lokeshh
Copy link
Member Author

lokeshh commented Feb 9, 2016

The problem is that this code from backports library fails to over write the class Prime.

I tried running Object.send(:remove_const, :Prime) before this line and it seems to work!

@v0dro
Copy link
Member

v0dro commented Feb 9, 2016

Wow great :\

Could you add the following code somewhere in daru.rb?

if RUBY_VERSION > "2.3.0"
  Object.send(:remove_const, :Prime)
end

I think that should fix it.

@lokeshh
Copy link
Member Author

lokeshh commented Feb 9, 2016

The backports library just got updated. The bug doesn't seem to be there anymore.

The build should pass now.

v0dro added a commit that referenced this pull request Feb 9, 2016
@v0dro v0dro merged commit 64eee00 into SciRuby:master Feb 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants