Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proptests for automaton compilation #59

Open
V0ldek opened this issue Nov 25, 2022 · 1 comment
Open

Proptests for automaton compilation #59

V0ldek opened this issue Nov 25, 2022 · 1 comment
Labels
acceptance: go ahead Reviewed, implementation can start area: proptest Improvements to proptest coverage type: reliability Tests, code quality
Milestone

Comments

@V0ldek
Copy link
Member

V0ldek commented Nov 25, 2022

Is your feature request related to a problem? Please describe.
In the unending quest to proptest all the things, we should have tests for the automata we compile. This is a big ask, since we don't really have automata infrastructure.

Describe the solution you'd like
The only reasonable proptest design for this seems to be fuzzing paths and checking whether they are accepted. We would take a query, compile the automaton, and then generate arbitrary paths that should be accepted by the query. The same for paths that should not be accepted.

This can be done for both the NFA and the DFA.

Describe alternatives you've considered
For our NFA -> minimal DFA code, we can also test parity between the input and output automaton. We can simulate both of them side by side, making sure they're the same. This might be a potential additional issue.

@V0ldek V0ldek added the type: feature New feature or request label Nov 25, 2022
@github-actions github-actions bot added the acceptance: triage Waiting for owner's input label Nov 25, 2022
@github-actions
Copy link

Tagging @V0ldek for notifications

@V0ldek V0ldek added this to the Future milestone Nov 25, 2022
@github-actions github-actions bot added acceptance: go ahead Reviewed, implementation can start and removed acceptance: triage Waiting for owner's input labels Nov 25, 2022
@V0ldek V0ldek added type: reliability Tests, code quality area: proptest Improvements to proptest coverage mod: compiler and removed type: feature New feature or request labels Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acceptance: go ahead Reviewed, implementation can start area: proptest Improvements to proptest coverage type: reliability Tests, code quality
Projects
Development

No branches or pull requests

1 participant