mirrored from https://chromium.googlesource.com/v8/v8.git
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[TurboFan] Fix type checks for lowering SpeculativeNumberBinop.
Ensure we only lower SpeculativeNumberBinops to a pure operator for non-string plain primitives. Previously we could lower if a value might be the-hole, however this would fail a CHECK in ConvertInputsToNumber which expects a plain primitive. BUG=chromium:772420 Change-Id: I0c755d10db7afd9cabfb638eca5662d70dfc8d51 Reviewed-on: https://chromium-review.googlesource.com/715717 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#48649}
- Loading branch information
Showing
3 changed files
with
31 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
// Copyright 2017 the V8 project authors. All rights reserved. | ||
// Use of this source code is governed by a BSD-style license that can be | ||
// found in the LICENSE file. | ||
|
||
// Flags: --allow-natives-syntax | ||
|
||
function foo(arg) { | ||
var value; | ||
// None of the branches of this switch are ever taken, but | ||
// the sequence means value could be the hole. | ||
switch (arg) { | ||
case 1: | ||
let let_var = 1; | ||
case 2: | ||
value = let_var; | ||
} | ||
// Speculative number binop with NumberOrOddball feedback. | ||
// Shouldn't be optimized to pure operator since value's phi | ||
// could theoretically be the hole (we would have already thrown a | ||
// reference error in case 2 above if so, but TF typing still | ||
// thinks it could be the hole). | ||
return value * undefined; | ||
} | ||
|
||
foo(3); | ||
foo(3); | ||
%OptimizeFunctionOnNextCall(foo); | ||
foo(3); |