Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desert Dream Issues #3

Closed
mras0 opened this issue Oct 18, 2021 · 14 comments
Closed

Desert Dream Issues #3

mras0 opened this issue Oct 18, 2021 · 14 comments

Comments

@mras0
Copy link
Contributor

mras0 commented Oct 18, 2021

Hi,

First: Great job on the webport! 👍 This is just random feedback after trying it out quickly, so take it for what it's worth and close at your convenience.

I used what it identifies as Kickstart 1.3 rev 34.005 in Firefox 93.0 and Edge 94.0.992.50 on Windows 10 (Intel i7-8665U, 48G RAM, Intel UHD Graphics 620/Nvida Geforce MX250 laptop). Didn't change any settings.

I tested with Disk 1 of Desert Dream and noticed:

  • If I changed tabs it just looped the current sound buffer (this maybe impacted the further tests. Emulation seems to be otherwise paused.
  • General sound glitches. I'm pretty tone deaf, but there's something off. Sorry I can't be more specific, maybe it's replaying the same buffer twice? (I could maybe record it if you don't notice it). CPU usage isn't noticeably different when it happens.
  • The emulation speed is off (missiles go through the space ship). I guess this is because it's based on an older vAmiga version (don't know how old, but High Density by Darkness crashes dirkwhoffmann/vAmiga#466 is still present :))
  • The screen is cut short in the morphing dot sphere part before (1..2..3..4..12000 dots) (could be vpos $100)
  • Wireframe tunnel after "Revolution" is missing (blank screen)

The last three are possibly because an old version of vAmiga was used, so just ignore that if it matches the desktop version.

@dirkwhoffmann
Copy link

@mras0: Thanks a lot for testing the emulator and reporting issues!
@mithrendal: The first thing you should check are the compatibility settings. Does the web version run in Blitter level 2 and are the disk drives emulated with original speed? In addition, please check the Agnus revision. Make sure you don't use the old OCS revision.

@mras0
Copy link
Contributor Author

mras0 commented Oct 18, 2021

NP! Let me know if there's any windows specific testing you want me to do.

FWIW I don't think floppy speed is an issue, as long as the demo loads it isn't too picky (IME). My personal benchmarks are Flower Power/Anarchy (triangle corruption/later crash if disk speed is too high) and Rink a dink redux (full use of the power of the Rob Northern loader). Longer list of previous troubles I've had. Both of those (and RSI-Megademo) seemed to load fine BTW.

@mithrendal
Copy link
Contributor

Ok I see the best will be I add the compatibility settings first and then also check the sound buffer size. I currently set it to 4096 maybe a bit too large.🤔 and therefore the looping? Honestly I was first shocked by the beauty of that demo 🤤 … it was also so beautiful with all the errors in it. 😅I will have to look at the video first I bet to know what is wrong and what is correct. 🤓will do in the next couple of days.

@dirkwhoffmann
Copy link

Just for the records. Here is a recording of part 1 of the demo in vAmiga 1.1b5:

https://www.youtube.com/watch?v=ZiclbqL5pFA

@mithrendal
Copy link
Contributor

The emulation speed is off (missiles go through the space ship).

@mras0 it seems fixed after adding compatibility and hardware settings. Was already on latest code from @dirkwhoffmann 🤤

Now the missiles destroy the fighter jet with the following settings. At least on my iPhone…

16117B71-F0B2-402E-92BB-9D2D5339FBCF

@mithrendal
Copy link
Contributor

mithrendal commented Oct 22, 2021

31F65791-0AFF-4EB3-89E1-63EC8799B95F

32650828-C848-4322-8632-984889FA74A3

time of rocket collision

@mras0
Copy link
Contributor Author

mras0 commented Oct 22, 2021

I can confirm that the graphics issues I noticed are fixed: Missile timing is right, morphing dot sphere is no longer cut short, wireframe tunnel appears. Darkness - High density also gets to second part, so timing issues seems to be resolved.

The sound issues are still present, but maybe it would be better to create one or two new separate issues to track those? I'll try to do a bit more testing to see if I can narrow it down. I tried enabling webGL, but it didn't help (didn't hurt either). Nothing out of the ordinary is printed in the debug console.

Regarding the wireframe tunnel: It matches the video @dirkwhoffmann posted, but that doesn't look right to me either, so maybe that's a vAmiga issue?

The screen flashes with almost blank frames, e.g. here at 6:27:
image

Also the lines appear "too solid" compared to what I expect (6:17):
image

This is from Winuae 4.9.0b36:
image

Here's a winuae statefile from the part:
desert_dream_2.zip

EDIT: I don't have a good amiga setup to capture from at the moment, but I found this recording that I think is a real capture (starts from 6:13).

@dirkwhoffmann
Copy link

so maybe that's a vAmiga issue?

Yes, it is. I don't know for sure, but I expect there is something wrong with the line Blitter.

@mras0 mras0 mentioned this issue Oct 23, 2021
@mithrendal
Copy link
Contributor

mithrendal commented Nov 18, 2021

upgraded to latest v1.0.7 vAmigaCore dirkwhoffmann/vAmiga@77ef105

@mras0 do you think we can close ?

@mras0
Copy link
Contributor Author

mras0 commented Nov 18, 2021

Yes, looks like we're ready for part 2 (which requires mouse support to get to) 😄

image

@mras0 mras0 closed this as completed Nov 18, 2021
@mithrendal
Copy link
Contributor

mithrendal commented Nov 18, 2021

@mras0 Cool 😎 then lets do it right now. Don’t know should I start with the touch mouse or the real mouse? Touch for iPhone iPad etc. And real mouse for the computer mice.

@mras0
Copy link
Contributor Author

mras0 commented Nov 18, 2021

I only have normal computers (that I test with anyway), so I can't help with the touch stuff. I recently added a (crappy) SDL backend for my own emulator: https://github.com/mras0/AmiEmu/blob/aa7b7a29f0d4b6230c12d2d14ce795196927ec1b/sdl_driver.cpp (but the relative mouse movement doesn't work correctly under WSL2, but maybe that's a windows issue). Still there might be something useful you can use. The keyboard codes (when you get to that part) comes from here: http://amigadev.elowar.com/read/ADCD_2.1/Libraries_Manual_guide/node0479.html

For demos (and test executables), just getting left and right mouse buttons to do something is fine, so I'd focus on that at first. You probably need some capture/release code for the mouse anyway, so that might be the first starting point.

@mithrendal
Copy link
Contributor

mithrendal commented Nov 18, 2021

I try with the real mouse first ... seems easier ... on javscript side there is the pointer lock API which is super simple and on the emulator side there is something called

// Emulates a mouse movement

void setXY(double x, double y);

void setDxDy(double dx, double dy);

in the mouse object ...

so should be fairly easy... the more tricky part becomes the touch stuff because I have to emulate a trackpad and the right mouse click ...

thanks for the links

@mithrendal
Copy link
Contributor

@mras0 mouse support is online we can check part2 😎...

next we should do the trackpad mouse for touch devices ... I will look into it tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants