Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phone stuck on screen after hangup #36

Closed
BCRP-James opened this issue Mar 24, 2022 · 11 comments
Closed

Phone stuck on screen after hangup #36

BCRP-James opened this issue Mar 24, 2022 · 11 comments

Comments

@BCRP-James
Copy link

BCRP-James commented Mar 24, 2022

We have an issue in our server where if someone hangs up the call, the person who did not open their phone to hangup will keep the phone & call notification on their screen, If they open the phone at any point after the call, both the notification will disappear and they will have to close their phone again as normal.
This is occuring with a fresh install of this resource. It is almost as if the container it is trying to remove isnt referenced but as I am not the best in .js I have been unable to prove this theory.

I did notice that after having the call hang up the person who did not hang up receives the below NUI error: (I've left this here even though I believe this to also appear after hanging up on the default qb-phone aswell)

Uncaught TypeError: Cannot read property 'icon' of undefined (@qb-phone/html/js/app.js:629)

@Howsn
Copy link

Howsn commented Mar 24, 2022

This is the same error I have, then its not only me.
If anyone got a fix for this I would love if you could share :D

@trclassic92
Copy link
Collaborator

We have an issue in our server where if someone hangs up the call, the person who did not open their phone to hangup will keep the phone & call notification on their screen, If they open the phone at any point after the call, both the notification will disappear and they will have to close their phone again as normal. This is occuring with a fresh install of this resource. It is almost as if the container it is trying to remove isnt referenced but as I am not the best in .js I have been unable to prove this theory.

I did notice that after having the call hang up the person who did not hang up receives the below NUI error: (I've left this here even though I believe this to also appear after hanging up on the default qb-phone aswell)

Uncaught TypeError: Cannot read property 'icon' of undefined (@qb-phone/html/js/app.js:629)

Can you please make a recreation video for us so we can see the issue.... Currently we are not seeing any issues with this...

@BCRP-James
Copy link
Author

BCRP-James commented Mar 27, 2022

I noticed after recording this I didnt show the console but as mentioned in the original this is recreatable by any player at any time, all they have to do is hangup during a phonecall and as seen in the first clip it will stay on their screen

https://streamable.com/u6t1xf

I have just noticed, if i place this within the [qb] folder it always resets itself back to the original qbcore phone, i have tried two or three fresh downloads and each time it will revert unless i place it in a different folder - could this be causing some weird interaction?

@llbooya
Copy link
Owner

llbooya commented Mar 27, 2022

I noticed after recording this I didnt show the console but as mentioned in the original this is recreatable by any player at any time, all they have to do is hangup during a phonecall and as seen in the first clip it will stay on their screen

https://streamable.com/u6t1xf

I have just noticed, if i place this within the [qb] folder it always resets itself back to the original qbcore phone, i have tried two or three fresh downloads and each time it will revert unless i place it in a different folder - could this be causing some weird interaction?

have you deleted the old one and cleared cache? i cant reproduce this error on my end im curious can you see if you get an error of any kind?

@BCRP-James
Copy link
Author

I have cleared cache on both the server & client.

My process to install this new phone is: close server, delete both client & server caches. delete old qb-phone. drag & drop new qb-phone into [qb]. when I do it this way I get the old QB-phone appear so then i close server clear cache and place it in [standalone] and i get this css rework load but then get the aforementioned bug.

If it is of any note the QB version I am running is from around 01/01/2022.

https://i.imgur.com/VxgJk8A.png screenshot from console

Cautious to upload the screenshot from my server cmd but the only reference in there is one line after the phone is asnwered which reads:

mstsc_7NU8eZHUXR

@llbooya
Copy link
Owner

llbooya commented May 29, 2022

did you ever figure this out cause it isnt a widespread thing and i could never recreate it

@llbooya llbooya closed this as completed May 29, 2022
@dwiprizzy
Copy link

any update for this error ?

@BCRP-James
Copy link
Author

BCRP-James commented Nov 11, 2022

I know at the time of posting, I found a fix that solved everything (I havent touched this stuff for upwards of 8 months at this time so my memory is patchy). I found the NUI messages that were being sent when the phonecall ended were being sent the wrong way round (the Outgoingcall was going to the incomingcall recipient & visa versa). As far as I am aware I simply switched the NUIMessages around and that solved it. (lines 368 - 421 for the 'CancelCall' function // namely the if statement starting on line 391)

I cannot give more details as when I check the files I still have locally they match back to the code found in this version.

@dwiprizzy
Copy link

@hdsunbed can you share the specific line ?

@BCRP-James
Copy link
Author

As mentioned should be the if statement starting on line 391

@dwiprizzy
Copy link

i think that a different script

@trclassic92 trclassic92 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants