Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding integration with polars #32

Merged
merged 1 commit into from Oct 30, 2021

Conversation

benjaminjellis
Copy link
Contributor

@benjaminjellis benjaminjellis commented Oct 28, 2021

Hi,

First off I've been playing around with the crate and I think it's really great.

One thing that I thought might be useful is to have integration with polars (i.e. something like pandas integration with sklearn in python)

I've added a new constructor method from_dataframe for the Dataset struct and packaged it under a new crate feature dataframe

I'm not sure if you're accepting contributions and whether a contribution like this would be something you'd want. Feel free to close the pr if not.

Let me know what you think!

Thanks :)

@vaaaaanquish
Copy link
Owner

@benjaminjellis Thx! It's great works! I'll review it within 3 days.

Copy link
Owner

@vaaaaanquish vaaaaanquish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vaaaaanquish vaaaaanquish merged commit fdac515 into vaaaaanquish:main Oct 30, 2021
@loxs
Copy link

loxs commented Mar 31, 2022

Hi, I'm getting this error

expected struct `polars_core::frame::DataFrame`, found struct `polars::prelude::DataFrame`

@benjaminjellis how are you using polars, are you using it from polars_core crate?

@benjaminjellis
Copy link
Contributor Author

Hi @loxs,

The usage that's tested is using something like

use polars::df;

An example of this is here

i.e. this crate uses polars not polars_core.

Hopefully that helps! Any more questions lmk!

Thanks :)

@loxs
Copy link

loxs commented Mar 31, 2022

Hm, it seems that it's because of polars version mismatch. I am using v 0.20 in the other parts of my software and this crate dpeneds on 0.16... seems like they did some reorg and types are no more compatible.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants