Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V24: ensure dev bundle isn't included in add-on #279

Closed
OlliTietavainenVaadin opened this issue Feb 24, 2023 · 4 comments
Closed

V24: ensure dev bundle isn't included in add-on #279

OlliTietavainenVaadin opened this issue Feb 24, 2023 · 4 comments

Comments

@OlliTietavainenVaadin
Copy link
Member

Describe your motivation
V24 add-on skeleton shouldn't generate a dev bundle because it's not an application, it's an add-on
Describe the solution you'd like
Do not generate dev bundle
Describe alternatives you've considered

@Legioth
Copy link
Member

Legioth commented Feb 24, 2023

It might be fine that a bundle is created since it helps speed up development of the add-on itself.

We should just make sure that the bundle is not included in the stuff that would be uploaded to Directory. It might potentially works in that way automatically since it might only pick sources from e.g. src/main/java and not from src/main/dev-bundle (I haven't tested).

@Artur-
Copy link
Member

Artur- commented Feb 24, 2023

The files in src/main/dev-bundle are never included in a jar or war

@OlliTietavainenVaadin OlliTietavainenVaadin changed the title V24: ensure dev bundle isn't generated V24: ensure dev bundle isn't included in add-on Feb 24, 2023
@czp13 czp13 added this to Needs triage in OLD Vaadin Flow bugs & maintenance (Vaadin 10+) via automation Mar 28, 2023
@mshabarov
Copy link

Can we close this issue or do we expect something to be fixed in Flow? I don't see what we should do/fix.

@mshabarov
Copy link

mshabarov commented Apr 4, 2023

We don't have a branch for V24 by the way. I'll make a ticket.

@mshabarov mshabarov closed this as not planned Won't fix, can't repro, duplicate, stale Sep 7, 2023
OLD Vaadin Flow bugs & maintenance (Vaadin 10+) automation moved this from Needs triage to Closed Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants