Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bakery installed on iOS homescreen redirects to Safari after login #631

Closed
johannesh2 opened this issue Jun 28, 2018 · 6 comments
Closed
Labels
Milestone

Comments

@johannesh2
Copy link
Contributor

Bakery can be installed to iPhone home screen and starts up correctly. After entering login credentials and pressing login button it opens up Safari instead of continuing to orders list view.

@johannesh2 johannesh2 added the bug label Jun 28, 2018
@alvarezguille
Copy link
Member

Check if explicit scope helps, right now manifest uses default

https://developers.google.com/web/fundamentals/web-app-manifest/#scope

@alvarezguille
Copy link
Member

Also check if "start_url": "login", makes sense

@alvarezguille alvarezguille added this to the Sprint 4 milestone Jul 6, 2018
@johannesh2
Copy link
Contributor Author

I can't reproduce this anymore with the internal demo, but it still fails with the public demo.

@alvarezguille
Copy link
Member

Maybe it was fixed when merging #634, we can verify with next deploy to public demo

@johannesh2 johannesh2 modified the milestones: Sprint 4, Sprint 5 Jul 19, 2018
@vlukashov vlukashov self-assigned this Jul 25, 2018
@vlukashov
Copy link

Turns out when the exact same .war file is deployed to a private app.fi instance, the issue does not happen. The only difference I have spotted is that demo.vaadin.com responds to the login POST request with 302 (Found) and Location: http://bakery-flow.demo.vaadin.com/ whereas my own app.fi instance responds with Location: /.

Note no https in the demo response: http://bakery-flow.demo.vaadin.com/

My current best guess is that Chrome on Android is not very strict in enforcing the PWA scope and allows handling this response inside the PWA as long as it eventually redirects to HTTPS (which does happen). And Safari is strict and immediately opens the browser as soon as the Location URL does not match the PWA scope.

Needs more investigation to figure out why demo.vaadin.com behaves that way.

@vlukashov
Copy link

Fixed by the service desk and Mikael in nginx config for:

  • bakery-flow.demo.vaadin.com
  • bakery-flow-spring.app.fi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants