Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in grid-dense-theme Recipe #308

Open
khauser opened this issue Oct 11, 2023 · 1 comment
Open

Bug in grid-dense-theme Recipe #308

khauser opened this issue Oct 11, 2023 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed recipe

Comments

@khauser
Copy link

khauser commented Oct 11, 2023

With the grid-dense-theme I'm able to compact a grid. But sometimes on different grids the first data line is higher than the others. Also the sample from the recipe has this problem. I have tested this with firefox and chrome.

@khauser khauser added help wanted Extra attention is needed recipe labels Oct 11, 2023
@samie samie added the bug Something isn't working label Oct 11, 2023
@khauser
Copy link
Author

khauser commented Oct 11, 2023

I played a little bit round and it seems to work with:

:host([theme~="dense"]) [part~="cell"] {
  min-height: var(--lumo-size-xxs);
}
:host([theme~="dense"]) {
  font-size: var(--lumo-font-size-xs);
}
:host([theme~="dense"]) [part~="cell"] ::slotted(vaadin-grid-cell-content) {
  padding: 1px var(--lumo-space-s);
}

:host([theme~="dense"]) [part~="first-row"] [part~="cell"]:not([part~="details-cell"]) {
  border-top: 0;
  min-height: var(--lumo-size-xxs);
}

So first-row does have it's own min-height declaration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed recipe
Projects
None yet
Development

No branches or pull requests

2 participants