Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong link on the Button component article #3536

Closed
UjfaA opened this issue Jul 10, 2024 · 2 comments · Fixed by #3559
Closed

Wrong link on the Button component article #3536

UjfaA opened this issue Jul 10, 2024 · 2 comments · Fixed by #3559

Comments

@UjfaA
Copy link
Contributor

UjfaA commented Jul 10, 2024

On the Button component article in Miscellaneous Style Variants segment there is a mention of a Link (component) and it appears as a link. As displayed it looks like it should lead to the Link component (?) article, but it leads to the Button article.

https://vaadin.com/docs/latest/components/button#miscellaneous-style-variants


If you think this issue is important, add a 👍 reaction to help the community and maintainers prioritize this issue.

@web-padawan
Copy link
Member

Thanks for the issue. Looking at #370 where this was added, I see the following comment:

// the link in the line above should not send the user anywhere

This is clearly confusing as there is no Link component, and the link does seem broken.

@rolfsmeds
Copy link
Contributor

Ok yeah there is absolutely no reason to have the word link be an actual link (nor capitalized to indicate such a component exists). Although Flow does have an Anchor component class for making links, I don't think we should link to that either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants