Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiSelectComboBox: selection list does not open to the top #5014

Closed
MarkusGemeinhardt opened this issue May 2, 2023 · 3 comments · Fixed by vaadin/web-components#5806
Closed

Comments

@MarkusGemeinhardt
Copy link

Description

Unlike the ComboBox, the selection list of the MultiSelectComboBox always folds out downwards at the bottom of the browser. This happens until the distance is smaller than the height of a single list entry. Compare this with the behaviour on the documentation page at vaadin documentation MultiSelectComboBox

Expected outcome

If there is not enough space for a list of at least 5 entries, the selection list must expand upwards, as with the ComboBox.

Minimal reproducible example

Example:
https://vaadin.com/docs/latest/components/multi-select-combo-box

Steps to reproduce

  1. Scroll a MultiSelectComboBox near the bottom of the browser
  2. Open the selection list - it always opens down

Environment

Vaadin version(s): V23+

Browsers

Issue is not browser related

@yuriy-fix
Copy link
Contributor

Let's verify that the latest overlay positioning fix is applied correctly.

@sissbruecker
Copy link
Contributor

There was a fix for this for combo box recently, it looks like this needs to be applied to MSCB as well: vaadin/web-components#5432

@sissbruecker
Copy link
Contributor

Applied the same fix to MSCB in v24.

In v23 the previous fix should also apply to MSCB, and I could not reproduce the issue with v23.3.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants