-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compilation errors on the generated code. #65
Comments
I can verify the same compilation errors. I did the following steps in an empty test directory.
Could you @manolo take a look at this? |
Yes, the basic sample from the README does not work anymore : $ gwt-api-generator --package=PolymerElements/paper-elements --pom returns the same errors. I'd love to help to get this fixed if @manolo could provide some pointers ? |
It's a Polymer comment change in paper-button.html (line 174) that causes this issue: before: now: It seems that the missing |
Can we be a bit more forgiving for this kind of errors in the comments when generating ? |
I am not committer to this project. $ bower install --save PolymerElements/paper-elements |
As a note, the Polymer team changed from Basically, I think the "name" function (at least for events) needs to take newlines into account. It doesn't make sense that an event name would span multiple lines. |
@komasoftware Using a split on newlines and taking the first line seems to fix the issue. camelCase: function(s) {
return (s.split('\n')[0] || '').replace(/^Polymer\./, '').replace(/[^\-\w\.]/g,'').replace(/(\b|-|\.)\w/g, function (m) {
return m.toUpperCase().replace(/[-\.]/g, '');
});
}, |
Back here. The change did not really solve the issue. Wondering if @manolo still plans to support this library. Otherwise I need to look into another solution and rewrite my code. I would really like to know ! |
I used an awful solution.
It's horrible, but it compiles. Then i had to use the fix mentioned here. The problem I have now is that in Chrome the PaperInput does not work. It is visible, but i can't get the focus. For what i could see, the compilation now is showing a lot of errors/warnings (?) like this one but with many components |
Fixed in ecb419c |
How can I "npm install -g vaadin/gwt-api-generator" a specific commit ecb419c ? Thx for all the work ! |
I installed following Polymer components
"dependencies": {
"google-drive": "GoogleWebcomponents/google-drive#^1.0.1",
"google-apis": "GoogleWebcomponents/google-apis#^1.1.5",
"google-signin": "GoogleWebcomponents/google-signin#^1.3.3",
"vaadin-grid": "vaadin/vaadin-grid#1.0.0",
"vaadin-combo-box": "vaadin/vaadin-combo-box#1.0.0",
"paper-elements": "PolymerElements/paper-elements#^1.0.7",
"iron-elements": "PolymerElements/iron-elements#^1.0.10",
"neon-elements": "PolymerElements/neon-elements#^1.0.0",
"vaadin-icons": "vaadin/vaadin-icons#1.0.0"
}
bunch of errors ...
The text was updated successfully, but these errors were encountered: