Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM Bundle needs different versions in Vaadin 24.4.4 #6549

Closed
subITCSS opened this issue Jun 27, 2024 · 6 comments · Fixed by vaadin/bundles#125
Closed

NPM Bundle needs different versions in Vaadin 24.4.4 #6549

subITCSS opened this issue Jun 27, 2024 · 6 comments · Fixed by vaadin/bundles#125
Labels

Comments

@subITCSS
Copy link

Describe the bug

We discoverd another problem with the new version:
To create our sbom we check the npm references and getting this error:

npm error code ELSPROBLEMS
npm error invalid: @open-wc/dedupe-mixin@1.4.0 /node_modules/@open-wc/dedupe-mixin

The Issue we discovered is that the vaadin-bundles requires the fixed version of 1.3.1 for it
image

while all components require the ^1.3.0 and as there is an 1.4.0 the system updates the dependency to 1.4.0 which clashes with the upper fixed definition.
image

So based on this the Versions should be both fix or flexible using the ^.

Expected-behavior

Both versions are defined identical

Reproduction

Check the npm dependencies.

System Info

Vaadin 24.4.4

@ZheSun88
Copy link
Contributor

Thanks for the ticket.. i have applied the fix to vaadin/bundles.

@subITCSS
Copy link
Author

subITCSS commented Jul 8, 2024

When will this be solved/merged?- This should be available in the 24.4.5 cause it is causing our pipeline to stop

@ZheSun88
Copy link
Contributor

ZheSun88 commented Jul 8, 2024

vaadin 24.4.5 has been released a few while ago. Can you test again?

@subITCSS
Copy link
Author

subITCSS commented Jul 8, 2024

So based on what i see - the version did not change/solve this. And based on the situatiuon that your PullRequest is still open - would clearify that.

@ZheSun88
Copy link
Contributor

ZheSun88 commented Jul 9, 2024

ah, i see.. sorry for the inconvenience, i will ask the team to merge those PRs and make another release ASAP

@ZheSun88
Copy link
Contributor

ZheSun88 commented Jul 9, 2024

Vaadin 24.4.6 has been released with the version fix in bundles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants