-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NPM Bundle needs different versions in Vaadin 24.4.4 #6549
Comments
Thanks for the ticket.. i have applied the fix to vaadin/bundles. |
When will this be solved/merged?- This should be available in the 24.4.5 cause it is causing our pipeline to stop |
vaadin 24.4.5 has been released a few while ago. Can you test again? |
So based on what i see - the version did not change/solve this. And based on the situatiuon that your PullRequest is still open - would clearify that. |
ah, i see.. sorry for the inconvenience, i will ask the team to merge those PRs and make another release ASAP |
Vaadin 24.4.6 has been released with the version fix in bundles |
Describe the bug
We discoverd another problem with the new version:
To create our sbom we check the npm references and getting this error:
The Issue we discovered is that the vaadin-bundles requires the fixed version of 1.3.1 for it
![image](https://private-user-images.githubusercontent.com/155952489/343730745-00c39b49-f9e5-4e15-8f4c-e9f0185d3c0d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQxNzY1MjUsIm5iZiI6MTcyNDE3NjIyNSwicGF0aCI6Ii8xNTU5NTI0ODkvMzQzNzMwNzQ1LTAwYzM5YjQ5LWY5ZTUtNGUxNS04ZjRjLWU5ZjAxODVkM2MwZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwODIwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDgyMFQxNzUwMjVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yMDJmOWFjYjJjYzcyYzU0NjE1NzcwZDA0OWZhNTg5YTg0YTFkODVjYjgwZjJkMGZlOTM5ZTA3ZDYwODQwYjE4JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.GkHvpfHv4CU36cOcMHKa0FVDVqNMERJZyac4BPZvXWw)
while all components require the ^1.3.0 and as there is an 1.4.0 the system updates the dependency to 1.4.0 which clashes with the upper fixed definition.
![image](https://private-user-images.githubusercontent.com/155952489/343730777-8bfff365-13b7-44fb-9b19-5d5988243219.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQxNzY1MjUsIm5iZiI6MTcyNDE3NjIyNSwicGF0aCI6Ii8xNTU5NTI0ODkvMzQzNzMwNzc3LThiZmZmMzY1LTEzYjctNDRmYi05YjE5LTVkNTk4ODI0MzIxOS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwODIwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDgyMFQxNzUwMjVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0zZTA5ODg4NzEwNWI4NTg5MWZkNWViOGJmYTZiNjQxYWY1YTBmOTU5ZDkzNmRiM2VmNWNlY2VhZTZjNmVjY2ZkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.lSz4UqHJDQkrAvQvlWmi9SXeGXlcq0vzUlrjwoRQNeQ)
So based on this the Versions should be both fix or flexible using the ^.
Expected-behavior
Both versions are defined identical
Reproduction
Check the npm dependencies.
System Info
Vaadin 24.4.4
The text was updated successfully, but these errors were encountered: