Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom style #138

Closed
TatuLund opened this issue Feb 19, 2019 · 3 comments
Closed

Add custom style #138

TatuLund opened this issue Feb 19, 2019 · 3 comments

Comments

@TatuLund
Copy link

In the current app starter there is read me file in the folder where custom style html file should be. It would be better to have simple style html file there and use it in main view.

Idea behind of this feature request is, that it is really commonly asked question and developers to struggle to get it right (i.e. paths, correct annotation, etc.)

@Legioth
Copy link
Member

Legioth commented Feb 20, 2019

I think we originally had something like that in the starter, along with a PolymerTemplate class and an the corresponding .html file. We removed those at some point because we wanted this starter to be as simple as possible. We instead introduced https://github.com/vaadin/beverage-starter-flow as a starter that uses a bunch of different core features.

@samie
Copy link
Member

samie commented Jan 28, 2020

We already made fix to the default spring starter in vaadin/skeleton-starter-flow-spring#126 adding 3 different examples of styling. Same should go here.

@anasmi
Copy link
Contributor

anasmi commented Jan 28, 2020

Changes were merged in master branch a couple of days ago #274

Closing this ticket due to it

@anasmi anasmi closed this as completed Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants