Spreadsheet: undo/redo results in a NPE

[vaadin-bot]

Originally by lorenzo.benvenuti

---

Steps to reproduce the issue:

1. Open the attached xlsx file
2. Select the cell containing "1"
3. Use the green square handle to drag the "1" value to other cells ("2", ..., "9")
4. CTRL-Z
5. CTRL-Y

=>

java.lang.NullPointerException
at org.apache.poi.hssf.record.cf.CellRangeUtil.intersect(CellRangeUtil.java:62)
at org.apache.poi.hssf.record.cf.CellRangeUtil.mergeRanges(CellRangeUtil.java:149)
at org.apache.poi.hssf.record.cf.CellRangeUtil.mergeCellRanges(CellRangeUtil.java:121)
at org.apache.poi.hssf.record.cf.CellRangeUtil.mergeCellRanges(CellRangeUtil.java:103)
at com.vaadin.addon.spreadsheet.command.CellShiftValuesCommand.getPaintedCellRange(CellShiftValuesCommand.java:85)
at com.vaadin.addon.spreadsheet.command.CellShiftValuesCommand.getSelectedCellReference(CellShiftValuesCommand.java:59)
at com.vaadin.addon.spreadsheet.SpreadsheetHistoryManager.changeSelection(SpreadsheetHistoryManager.java:222)
at com.vaadin.addon.spreadsheet.SpreadsheetHistoryManager.redo(SpreadsheetHistoryManager.java:134)
at com.vaadin.addon.spreadsheet.SpreadsheetHandlerImpl.onRedo(SpreadsheetHandlerImpl.java:225)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at com.vaadin.server.ServerRpcManager.applyInvocation(ServerRpcManager.java:168)
at com.vaadin.server.ServerRpcManager.applyInvocation(ServerRpcManager.java:118)
at com.vaadin.server.communication.ServerRpcHandler.handleInvocations(ServerRpcHandler.java:291)
at com.vaadin.server.communication.ServerRpcHandler.handleRpc(ServerRpcHandler.java:184)
at com.vaadin.server.communication.UidlRequestHandler.synchronizedHandleRequest(UidlRequestHandler.java:92)
at com.vaadin.server.SynchronizedRequestHandler.handleRequest(SynchronizedRequestHandler.java:41)
at com.vaadin.server.VaadinService.handleRequest(VaadinService.java:1408)
at com.vaadin.server.VaadinServlet.service(VaadinServlet.java:350)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:769)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1667)
at org.eclipse.jetty.websocket.server.WebSocketUpgradeFilter.doFilter(WebSocketUpgradeFilter.java:172)
at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1650)
at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:583)
at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:577)
at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:223)
at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1125)
at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:515)
at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1059)
at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
at org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:215)
at org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:110)
at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:97)
at org.eclipse.jetty.server.Server.handle(Server.java:497)
at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:311)
at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:248)
at org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:540)
at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:610)
at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:539)
at java.lang.Thread.run(Thread.java:745)

---

Imported from https://dev.vaadin.com/ issue #19100

[vaadin-bot]

Originally by lorenzo.benvenuti

---

Attachment added: undo.xlsx (7.8 KiB)

[vaadin-bot]

Originally by @Ansku

---

https://dev.vaadin.com/review/13343