Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional formatting disables the formula evaluation #667

Closed
kiaruska opened this issue Jul 4, 2018 · 7 comments
Closed

Conditional formatting disables the formula evaluation #667

kiaruska opened this issue Jul 4, 2018 · 7 comments
Assignees
Milestone

Comments

@kiaruska
Copy link

kiaruska commented Jul 4, 2018

The issue is related to conditional formatting and formulas evaluation.
We have attached a sample where we have reproduced the case.

To reproduce the problem, follow these steps:

Change the value of cell "A2" from '2018/07 to '2018/05
The cell F2 is not revaluated from the spreadsheet

The problem seems caused by a chain of dependencies:

The color of B2 depends from the value of H2
The value of H2 depends from the value of F2
The value of F2 depends from the value of A2

If we broke the double redirection (if B2 depends directly from A2 and F2 depends from A2 too), the problem doesn't rise anymore.

Evaluation_formula_issue.xlsx

@DiegoCardoso DiegoCardoso added this to the Sprint 5 milestone Jul 23, 2018
@DiegoCardoso DiegoCardoso self-assigned this Jul 23, 2018
@kiaruska
Copy link
Author

Thanks for the planification of the issue analysis.
We would need the fix on 1.4 version.
If you need more information about the issue, you can ask me.

@johannesh2 johannesh2 modified the milestones: Sprint 5, Sprint 6 Aug 6, 2018
@alvarezguille
Copy link
Member

Hi @kiaruska

We have been checking this issue. It looks like a duplicate of #576.

This could be fixed by updating to POI 3.17, but last time we checked it caused some regressions, that's why we need to be careful about it, we're checking those regressions at the moment.

@alvarezguille alvarezguille modified the milestones: Sprint 6, Sprint 7 Aug 16, 2018
@tulioag tulioag self-assigned this Aug 22, 2018
@alvarezguille
Copy link
Member

We have concluded that this issue should be fixed by upgrading POI version to 3.17.
As it was mentioned before POI 3.17 caused a regression with some cases of conditional formatting 61761 and 61764
This change will be released in new minor versions of Spreadsheet, version compatible with Vaadin Framework 7 will be 1.5 and the regression will be clarified in release notes and documentation.
@kiaruska is this regression something that would prevent from using Spreadsheet 1.5? Any comment about suggested solution?

@kiaruska
Copy link
Author

Hi @alvarezguille ,
what are the regressions that will be introduced?
The issues 61761 and 61764 are closed.
I followed the thread #648 but this is about 3.17 beta version.
If there aren't others known regressions, I haven't observations about the POI updating.
Thanks
Chiara

@alvarezguille
Copy link
Member

61761 and 61764 are the regressions which are closed but not included in 3.17 final, according to the comment in 61761 the fix will be part of 4.0.x.

@kiaruska
Copy link
Author

I see, thanks.
I agree with your proposal to release a new minor versions of Spreadsheet, version compatible with Vaadin Framework 7, clarifying the regressions in release notes and documentation.

@alvarezguille alvarezguille modified the milestones: Sprint 7, Sprint 8 Aug 30, 2018
@tulioag
Copy link
Contributor

tulioag commented Sep 6, 2018

Spreadsheet 1.5.0.alpha1 is released https://github.com/vaadin/spreadsheet/releases/tag/1.5.0.alpha1.

@kiaruska, please test it and let us know if you have issues.

@tulioag tulioag closed this as completed Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants