Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow TestBench usage without subclassing #1291

Closed
skiedrowski opened this issue Apr 21, 2021 · 2 comments
Closed

allow TestBench usage without subclassing #1291

skiedrowski opened this issue Apr 21, 2021 · 2 comments

Comments

@skiedrowski
Copy link

Enforcing subclassing of TestBenchTestCase makes integration in various contexts problematic.

If I would try to implement a Test using TestBench and another tool which forces subclassing of its own XyzTestCase, it would be impossible to use both.

UI Testing is just one aspect of a test, but very often not the only aspect.

JUnit 4 provides Rules, JUnit 5 provides Extensions and I guess TestNG also has a convenient way to integrate with multiple test libraries.

It would be great if Vaadin could provide a TestBenchRule for JUnit 4 and a TestBenchExtension for JUnit 5 if that would allow dropping the extends TestBenchTestCase.

@skiedrowski skiedrowski changed the title allow TestBench usage with subclassing allow TestBench usage without subclassing Apr 30, 2021
@MarcinVaadin
Copy link
Member

I'm currently on JUnit5 migration and that's a good point. I've already switched to extensions but still parent class is required. I will analyze it and try to do some PoC's within #1551

@MarcinVaadin
Copy link
Member

Done, will be available in 9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants