Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helper component should be queried from the root level #1299

Open
tomivirkki opened this issue Sep 21, 2021 · 1 comment
Open

Helper component should be queried from the root level #1299

tomivirkki opened this issue Sep 21, 2021 · 1 comment

Comments

@tomivirkki
Copy link
Member

HasHelper interface's default implementation for getHelperComponent() does a query for [slot='helper']. It may result in unintentionally returning the helper component of a child component.

Example:

<vaadin-custom-field>
  <vaadin-combo-box>
    <div slot="helper">Helper</div>
  </vaadin-combo-box>
</vaadin-custom-field>

CustomFieldElement's getHelperComponent() would in this case return the helper of <vaadin-combo-box>.

Change the implementation to only search for helpers on the root level.

@tomivirkki tomivirkki added the bug label Sep 21, 2021
@mshabarov mshabarov added this to Needs triage in OLD Vaadin Flow bugs & maintenance (Vaadin 10+) via automation Jan 31, 2023
@mshabarov
Copy link
Contributor

@alvarezguille do you have an idea what is the severity and impact of this issue?

@mshabarov mshabarov moved this from Needs triage to New P2 in OLD Vaadin Flow bugs & maintenance (Vaadin 10+) Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🔖 Normal Priority (P2)
Development

No branches or pull requests

2 participants