Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timeSpentRenderingLastRequest does not work with Vaadin 15+ #1316

Closed
Artur- opened this issue Feb 8, 2022 · 0 comments · Fixed by #1715
Closed

timeSpentRenderingLastRequest does not work with Vaadin 15+ #1316

Artur- opened this issue Feb 8, 2022 · 0 comments · Fixed by #1715
Labels
bug
Projects
OLD Vaadin Flow bugs & maintenance (V...

Comments

@Artur-
Copy link
Member

Artur- commented Feb 8, 2022

Calling timeSpentRenderingLastRequest always throws Performance data is not available in production mode, even in development mode.

This is because

testbench/vaadin-testbench-core/src/main/java/com/vaadin/testbench/commands/TestBenchCommandExecutor.java

Line 211 in 06dcf3d

+ " if (!window.Vaadin.Flow.clients[client].getProfilingData) {"
finds a window.Vaadin.Flow.clients.TypeScript which does not contain anything else than isActive
@mshabarov mshabarov added this to Needs triage in OLD Vaadin Flow bugs & maintenance (Vaadin 10+) via automation Nov 29, 2022
@mcollovati mcollovati added the bug label Dec 13, 2022
@mcollovati mcollovati moved this from Needs triage to New P2 in OLD Vaadin Flow bugs & maintenance (Vaadin 10+) Dec 13, 2022
@tepi tepi mentioned this issue Dec 20, 2023
Merged
OLD Vaadin Flow bugs & maintenance (Vaadin 10+) automation moved this from Normal Priority (P2) to Closed Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
OLD Vaadin Flow bugs & maintenance (V...
Closed
Vaadin Flow bugs & maintenance (Vaadin 10+)
Status: ✅ Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix performance data fetching vaadin/testbench
2 participants
@Artur- @mcollovati