Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests should wait for the router to complete routing operations #1626

Open
Artur- opened this issue Mar 31, 2023 · 1 comment
Open

Tests should wait for the router to complete routing operations #1626

Artur- opened this issue Mar 31, 2023 · 1 comment

Comments

@Artur-
Copy link
Member

Artur- commented Mar 31, 2023

If you have a TypeScript view in your app, e.g.

    {
        path: 'hello',
        component: 'hello-world-view',
        action: async () => {
            await import('./typescript/hello-world-view');
        },
    },

and you have a test that opens /hello then it would be expected that the test waits until hello-world-view has been imported and rendered before proceeding. Right now, it proceeds as soon as the index page has been rendered and router just started fetching hello-world-view

@platosha platosha added the hilla label Mar 31, 2023
@mshabarov mshabarov added the bug label Apr 4, 2023
@mshabarov mshabarov added this to Needs triage in OLD Vaadin Flow bugs & maintenance (Vaadin 10+) via automation Apr 4, 2023
@mshabarov mshabarov moved this from Needs triage to New P2 in OLD Vaadin Flow bugs & maintenance (Vaadin 10+) Apr 4, 2023
@platosha
Copy link

Note that with React projects Hilla uses a different router with its own ways for lazy loading views.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🔖 Normal Priority (P2)
Development

No branches or pull requests

3 participants