Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VoiceOver announces the button label twice #127

Closed
jouni opened this issue Feb 18, 2019 · 2 comments
Closed

VoiceOver announces the button label twice #127

jouni opened this issue Feb 18, 2019 · 2 comments
Projects
vaadin-core

Comments

@jouni
Copy link
Member

jouni commented Feb 18, 2019

Using VoiceOver on the demo page, focusing the first button announces “Button Button, button”:
https://cdn.vaadin.com/vaadin-button/2.1.3/demo/#button-basic-demos (edited)
@tomivirkki tomivirkki added the needs triage Has to be triaged by the team label Feb 18, 2019
@web-padawan
Copy link
Member

Appears to be caused by #122 and #125. Should we revert these changes?
Was the LightHosue warning incorrect (that was the reason to do that)?

@jtomass jtomass added this to Issue Backlog in vaadin-core Mar 29, 2019
@web-padawan web-padawan mentioned this issue Apr 10, 2019
Closed
@web-padawan
Copy link
Member

Closing as the code introducing this has been reverted and fix released in 2.1.5

vaadin-core automation moved this from Issue Backlog to ✅ Done Apr 10, 2019
@web-padawan web-padawan removed the needs triage Has to be triaged by the team label Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
vaadin-core
  
✅ Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jouni @tomivirkki @web-padawan