Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrolling is broken in Lumo on small viewport sizes #247

Closed
jouni opened this issue Jun 18, 2019 · 0 comments · Fixed by #249
Closed

Scrolling is broken in Lumo on small viewport sizes #247

jouni opened this issue Jun 18, 2019 · 0 comments · Fixed by #249
Assignees
@yuriy-fix
Labels
bug Something isn't working

Comments

@jouni
Copy link
Member

jouni commented Jun 18, 2019

If the content inside the overlay is larger than 80vh, it is really difficult for the user to scroll all content visible on small viewport sizes.

Caused by the 80vh limit in the Lumo theme, which does not take into account that the menu-overlay mixin already has a 50vh max-height set for the overlay part and that the content part is the one scrolling and should inherit the max-height from the overlay part: https://github.com/vaadin/vaadin-lumo-styles/blob/master/mixins/menu-overlay.html#L57-L73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuriy-fix yuriy-fix

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove max-height from content as it's present in lumo-styles vaadin/vaadin-context-menu
2 participants
@jouni @yuriy-fix