Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate focused property #26

Closed
platosha opened this issue Sep 29, 2017 · 3 comments
Closed

Deprecate focused property #26

platosha opened this issue Sep 29, 2017 · 3 comments
Assignees
Milestone

Comments

@platosha
Copy link
Contributor

platosha commented Sep 29, 2017

The focused state should not end up in public API.

Instead (document || shadowRoot).activeElement standard DOM API should be used to find focused element. Focus change notification triggers standard focus events.

Include #23

@jouni
Copy link
Member

jouni commented Sep 29, 2017

Does this mean that the [focused] state attribute is also removed? I suppose we need to rely on the :focus pseudo-class instead then, right?

@platosha
Copy link
Contributor Author

Nope. The attribute should be kept for styling purposes.

:focus pseudo-class is unreliable for host styling. Obviously, it wouldn’t match the host when the actual focused element is in shadow DOM.

@jouni
Copy link
Member

jouni commented Sep 29, 2017

Ah, of course – I didn’t actually think about this too much :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants