Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vaadin date picker light - material theme - is missing single disabled dates styling #636

Closed
7 tasks done
AndreSilva1993 opened this issue Feb 21, 2019 · 2 comments · Fixed by #664
Closed
7 tasks done
Assignees
Labels
bug Something isn't working
Projects

Comments

@AndreSilva1993
Copy link

AndreSilva1993 commented Feb 21, 2019

Description

In the following file theme/material/vaadin-month-calendar-styles.html there should be a rule to style individual disabled dates in a month like there is in the default lumo style (https://github.com/vaadin/vaadin-date-picker/blob/master/theme/lumo/vaadin-month-calendar-styles.html#L119).

Including the following rule in the file theme/material/vaadin-month-calendar-styles.html fixes the issue:

[part="date"][disabled] {
  color: var(--material-disabled-text-color);
}

Expected outcome

The single disabled days in a month should be greyed out like in the lumo style.

Actual outcome

The days are correctly disabled as the user can't select them but the color remains unaltered which does not happen in the default lumo style.

Steps to reproduce

  1. Put a vaadin-date-picker-light element in the page and apply the material theme.
  2. Define a min date as 2019-02-15 for instance.
  3. Open the datepicker.
  4. The previous days in February should be greyed out which is not currently happening.

Browsers Affected

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE 11
  • iOS Safari
  • Android Chrome
@realansgar
Copy link

This also happens when using the not light version, probably because the material styles get reused between both versions.

Live Example

vaadin-date-picker material disabled bug

image

@realansgar
Copy link

Possible Fix

In .../vaadin-date-picker/theme/material/vaadin-month-calendar-styles.html at line 31 add this snippet:
[part="date"][disabled],
image

@jtomass jtomass added this to 📬  Inbox in vaadin-core Mar 29, 2019
@web-padawan web-padawan added the bug Something isn't working label Jun 12, 2019
@web-padawan web-padawan self-assigned this Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
vaadin-core
  
📬  Inbox
Development

Successfully merging a pull request may close this issue.

3 participants