Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation: Make JavaDoc of Grid#setClassNameGenerator more precise #651

Merged
merged 4 commits into from Mar 31, 2021

Conversation

TatuLund
Copy link
Contributor

Classname generator is cell based. If using Grid#setClassNameGenerator, it populates each cell in the row with the classname, not the row element. This is important to know, as it rules out certain styling options.

Classname generator is cell based. If using Grid#setClassNameGenerator, it populates each cell in the row with the classname, not the row element. This is important to know, as it rules out certain styling options.
@TatuLund
Copy link
Contributor Author

@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 32 issues

  • CRITICAL 2 critical
  • MAJOR 8 major
  • MINOR 19 minor
  • INFO 3 info

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL Grid.java#L2397: Remove usage of generic wildcard type. rule
  2. CRITICAL Grid.java#L3155: Define a constant instead of duplicating this literal "direction" 4 times. rule
  3. MAJOR Grid.java#: This file has 1,847 lines, which is greater than 750 authorized. Split it into smaller files. rule
  4. MAJOR Grid.java#L1933: Call "Optional#isPresent()" before accessing the value. rule
  5. MAJOR Grid.java#L1934: Either log or rethrow this exception. rule
  6. MAJOR Grid.java#L1953: Either log or rethrow this exception. rule
  7. MAJOR Grid.java#L2963: Call "Optional#isPresent()" before accessing the value. rule
  8. MAJOR Grid.java#L2973: Call "Optional#isPresent()" before accessing the value. rule
  9. MAJOR Grid.java#L3706: Rename "editor" which hides the field declared at line 1190. rule
  10. MAJOR Grid.java#L4117: Remove this unused method parameter "event". rule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants