Add test and fix scroll to

vaadin · Oct 26, 2020 · 0c8de60 · 0c8de60
1 parent 98deb3f
commit 0c8de60
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 0 deletions.
diff --git a/src/vaadin-grid-scroll-mixin.html b/src/vaadin-grid-scroll-mixin.html
@@ -130,6 +130,10 @@
      * @param {number} index Row index to scroll to
      */
     scrollToIndex(index) {
+      if (index > this._physicalCount) {
+        this._increasePoolIfNeeded(0);
+        this._debounceIncreasePool && this._debounceIncreasePool.flush();
+      }
       this._accessIronListAPI(() => super.scrollToIndex(index));
     }
 

diff --git a/test/scroll-to-index.html b/test/scroll-to-index.html
@@ -150,6 +150,26 @@
 
       });
 
+      describe('Physical pool', () => {
+        let grid, scroller, data;
+
+        beforeEach(() => {
+          grid = fixture('large');
+          data = Array(...new Array(200)).map((_, i) => {
+            return {'index': i};
+          });
+          grid.items = data.splice(0, 10);
+          flushGrid(grid);
+        });
+
+        it('should scroll to pushed index', () => {
+          grid.push('items', data[grid.items.length]);
+          grid.scrollToIndex(grid.items.length);
+
+          expect(grid.$.items.children[0]._item.index).to.equal(0);
+        });
+      });
+
     });
   </script>