Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grid] Add "hidable" property to column #1833

Open
denis-anisimov opened this issue Sep 23, 2018 · 8 comments
Open

[grid] Add "hidable" property to column #1833

denis-anisimov opened this issue Sep 23, 2018 · 8 comments
Labels
enhancement New feature or request Impact: High needs design Design is needed vaadin-grid
Projects

Comments

@denis-anisimov
Copy link

vaadin-grid-column component has an attribute hidden which allows to show/hide the column.

But there is no way to mark column as hidable. Such column should allow to hide the column for the user (or disable that functionality).

See the Java API method for Grid column in FW8:
https://github.com/vaadin/framework/blob/master/server/src/main/java/com/vaadin/ui/Grid.java#L1835

Please add support for this.

@jouni
Copy link
Member

jouni commented Sep 24, 2018

Isn’t it enough to add a hidable attribute on the element to track which columns are hidable? I don’t see the need to have any special support for this in the component implementation. Or is it necessary to receive a changed event for this?

@denis-anisimov
Copy link
Author

I don't know.........

Is hidable attribute supported ?

As I understand the hidable property/attribute means that there is a UI control available for the column on the client side which allows to hide the column (though I don't know how it should be set visible back after hiding).
I don't remember the Grid behavior on FW8 regarding this feature.
Sorry, can't find any FW8 component demo on our website.....

@jouni
Copy link
Member

jouni commented Sep 24, 2018

Oh, so this is about having the UI as well. I was just thinking that you needed to keep track of the columns which the user can hide/show.

We need a UI design for this.

@jouni
Copy link
Member

jouni commented Sep 24, 2018

Also, after this gets implemented, we can close vaadin/vaadin-grid#819

@denis-anisimov
Copy link
Author

Sure

@rolfsmeds rolfsmeds changed the title vaadin-grid-column: There is no way to make column hidable Column visibility toggle feature (as in V8 Grid) Mar 9, 2020
@scrmtrey91
Copy link

will this be implemented in vaadin 14:

addColumnVisibilityChangeListener

????

@scrmtrey91
Copy link

and also this :

  • setHidable on column when adding column

@rolfsmeds rolfsmeds changed the title Column visibility toggle feature (as in V8 Grid) Add "hidable" property to column Feb 26, 2021
@rolfsmeds
Copy link
Contributor

Renamed this, and keeping it open for the hidability property, and keeping vaadin/web-components#1569 for the UI for toggling columns.

@vaadin-bot vaadin-bot transferred this issue from vaadin/vaadin-grid May 19, 2021
@vaadin-bot vaadin-bot added enhancement New feature or request needs design Design is needed vaadin-grid labels May 19, 2021
@web-padawan web-padawan changed the title Add "hidable" property to column [grid] Add "hidable" property to column May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Impact: High needs design Design is needed vaadin-grid
Projects
No open projects
vaadin-core
  
📬  Inbox
Development

No branches or pull requests

5 participants