Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hidden column causing exceptions since 5.6.0 #1729

Closed
7 tasks done
robrez opened this issue May 6, 2020 · 3 comments · Fixed by #1735
Closed
7 tasks done

Hidden column causing exceptions since 5.6.0 #1729

robrez opened this issue May 6, 2020 · 3 comments · Fixed by #1735
Assignees
@tomivirkki
Labels
Impact: Low Severity: Blocker

Comments

@robrez
Copy link

robrez commented May 6, 2020

Description

Receiving errors since 5.6.0

Uncaught TypeError: Cannot read property '_content' of undefined
    at HTMLElement.ColumnBaseMixin.__runRenderer (vaadin-grid-column.js:242)
    at HTMLElement.ColumnBaseMixin._renderHeaderAndFooter (vaadin-grid-column.js:235)
    at eval (vaadin-grid.js:771)
    at Array.forEach (<anonymous>)
    at eval (vaadin-grid.js:771)
    at Array.forEach (<anonymous>)
    at HTMLElement.GridElement.render (vaadin-grid.js:770)

Live Demo

https://stackblitz.com/edit/typescript-ybspyn

Steps to reproduce

  1. Have a column start out as hidden
  2. Manually run grid.render()

In the repro above, I had made the connection to rendering ... but the repro is over-complicated - it copied a v-grid selection demo because that was closer to my production code. It appears all that is necessary is just running render

grid-5 6 0-hidden-col

Browsers Affected

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE 11
  • iOS Safari
  • Android Chrome
@tomivirkki tomivirkki self-assigned this May 12, 2020
@tomivirkki tomivirkki mentioned this issue May 12, 2020
Merged
@robrez
Copy link
Author

robrez commented May 20, 2020

Will 5.6.x be tagged, or, is the plan to wait on 5.7.0?

@web-padawan
Copy link
Member

@robrez sorry for the delay, submitted a PR to cherry-pick: #1736

@web-padawan
Copy link
Member

Released 5.6.2 with a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomivirkki tomivirkki

Labels
Impact: Low Severity: Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't run renderers for missing header/footer cells vaadin/vaadin-grid
3 participants
@tomivirkki @robrez @web-padawan