Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing attribute selected-rows throws an Error #3

Closed
Saulis opened this issue Apr 10, 2015 · 2 comments
Closed

Removing attribute selected-rows throws an Error #3

Saulis opened this issue Apr 10, 2015 · 2 comments
Assignees
@manolo
Labels
bug Something isn't working
Projects
vaadin-core

Comments

@Saulis
Copy link
Contributor

Saulis commented Apr 10, 2015

Given a <v-grid selected-rows="0"></v-grid>

Removing the attribute from DOM or with JS grid.removeAttribute('selected-rows');

Throws:
Error: Uncaught TypeError: Cannot read property 'split' of null (/Users/Saulis/Dev/components/vaadin-components/vaadin-grid/vaadin-grid.html:40)

Instead, should set grid.selectedRows to [] or undefined

Test located here
@manolo manolo added the bug Something isn't working label Apr 21, 2015
@manolo manolo self-assigned this Apr 21, 2015
@manolo manolo added in progress and removed bug Something isn't working in progress labels Apr 21, 2015
@jouni jouni added the bug Something isn't working label Apr 21, 2015
@manolo
Copy link
Member

manolo commented Apr 21, 2015

In review: https://dev.vaadin.com/review/#/c/8461/

@jouni jouni added in progress and removed ready labels Apr 21, 2015
@manolo manolo added ready and removed in progress labels Apr 21, 2015
@jouni
Copy link
Member

jouni commented May 8, 2015

Clean up old test issue.

@jouni jouni closed this as completed May 8, 2015
@zeidoo zeidoo mentioned this issue Aug 23, 2017
Closed
@jtomass jtomass added this to 🏗  In Progress in vaadin-core Mar 29, 2019
@web-padawan web-padawan moved this from 🏗  In Progress to ✅ Done in vaadin-core Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manolo manolo

Labels
bug Something isn't working
Projects
No open projects
vaadin-core
  
✅ Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jouni @manolo @Saulis @web-padawan