Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LitElement conversion part 1: cleanup #133

Closed
web-padawan opened this issue Mar 12, 2020 · 1 comment
Closed

LitElement conversion part 1: cleanup #133

web-padawan opened this issue Mar 12, 2020 · 1 comment
Assignees
Labels
next LitElement based version issue

Comments

@web-padawan
Copy link
Member

README.md

Align with skeleton:

  • remove mentions of Bower and HTML Imports

  • align and move badges below the description

  • add pre-release note before the code snippet

    • mention Vaadin 14 compatible branches (example)
  • update "Running demos and API docs in a browser" section

  • update "Running tests from the command line" section

  • update "Following the coding style" section

vaadin-directory-description.md

  • align badges with README, remove Bower badge

  • check that code snippet and image look good

package.json

  1. Update package.json to align with package.json:
  • update vaadin-component-dev-dependencies version

  • update main entry to point to a single .js file

  • add module entry which should be the same as main

  • add "dependencies" based on Bower dependencies

  • update "files" section to include d.ts etc

  • update "scripts" section. Note the analyze script

  1. Remove bower.json file.

Hint: commit with --no-verify flag to bypass Git hooks.

Config files

  1. Update the files to align with skeleton:
  • .eslintrc.json
  • .gitignore
  • .travis.yml
  1. Copy the following files from skeleton:
  • babel.config.js
  • .prettierrc
  • tsconfig.json (update the "include" section)

Cleanup

  1. Remove demo folder completely

  2. Remove wct.conf.js file

  3. Remove test/.eslintrc.json file

  4. Remove test/test-suites.js file

  5. Remove test/index.html file

@web-padawan web-padawan added the next LitElement based version issue label Mar 12, 2020
@web-padawan web-padawan self-assigned this Mar 18, 2020
@web-padawan
Copy link
Member Author

Done by #138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next LitElement based version issue
Projects
None yet
Development

No branches or pull requests

1 participant