New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LitElement conversion part 2: src and unit tests #134

Closed

web-padawan opened this issue Mar 12, 2020 · 1 comment

Assignees

Labels

next

Member

web-padawan commented Mar 12, 2020

Config tweaks

Remove npm run test:visual from .travis.yml
Remove theme from lint:js npm script (ESLint)

Convert src

Convert src files to LitElement using this structure:

vaadin-split-layout-css.ts - default styles
vaadin-split-layout-base.ts - base class (extend VaadinElement)
vaadin-split-layout-mixin.ts - mixin containing component logic
vaadin-split-layout.ts - custom element definition

Convert tests

Convert unit tests in test/unit folder. Use the test helpers:

@vadin/vaadin-components-dev-dependencies/testing.js
@vadin/vaadin-components-dev-dependencies/keys.js

Coverage

run es-dev-server and go to http://localhost:8000/coverage/
adjust coverage thresholds in karma.conf.js as necessary

The text was updated successfully, but these errors were encountered:

web-padawan added the next label

web-padawan self-assigned this

web-padawan mentioned this issue

LitElement conversion part 2: src and unit tests #139

Merged

Member Author

web-padawan commented Mar 27, 2020

Done by #139

web-padawan closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment