Even disabled, vaadin-usage-statistics pollutes window.localStorage

[jimbojw]

Per the instructions on how to opt-out, the vaadin-usage-statistics.js file is indeed empty:

$ cat ./node_modules/@vaadin/vaadin-usage-statistics/vaadin-usage-statistics.js 
export const usageStatistics = function() {
  /* do nothing */
};

However, in the browser, the window.localStorage object continues to have usage statistics inserted. Running the following code in the console reveals the violation:

for (let i = 0; i < localStorage.length; i++) {
  console.log(i, localStorage.key(i));
}

Console output:

0 vaadin.statistics.firstuse
1 vaadin.statistics.basket

[jimbojw]

Note: I'm not using this project directly. It is a dependency of @vaadin/router.

[yuriy-fix]

@Artur- , is it an expected behaviour?

[jimbojw]

If it is expected, do I need to make a separate issue to feature request a disable flag? Or could this issue stand-in for such a request?

[Artur-]

I think this might be a problem with how router is distributed. It currently bundles its dependencies into one JS file, which means it is unable to pick up the optout version of vaadin-usage-statistics.js. If so, then vaadin/router#828 should solve this