fix: allow null and undefined for errorMessage (#3066) (#3067)

Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
vaadin · Nov 17, 2021 · 00b7087 · 00b7087
1 parent 0a97f54
commit 00b7087
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/packages/date-picker/test/typings/date-picker.types.ts b/packages/date-picker/test/typings/date-picker.types.ts
@@ -59,7 +59,7 @@ assertType<boolean>(datePicker.invalid);
 assertType<HTMLElement | null | undefined>(datePicker.focusElement);
 assertType<boolean>(datePicker.disabled);
 assertType<boolean>(datePicker.clearButtonVisible);
-assertType<string>(datePicker.errorMessage);
+assertType<string | null | undefined>(datePicker.errorMessage);
 assertType<string>(datePicker.placeholder);
 assertType<string | null | undefined>(datePicker.helperText);
 assertType<boolean>(datePicker.readonly);

diff --git a/packages/date-time-picker/test/typings/date-time-picker.types.ts b/packages/date-time-picker/test/typings/date-time-picker.types.ts
@@ -19,7 +19,7 @@ assertType<boolean>(picker.required);
 assertType<boolean>(picker.invalid);
 assertType<boolean>(picker.disabled);
 assertType<boolean>(picker.readonly);
-assertType<string>(picker.errorMessage);
+assertType<string | null | undefined>(picker.errorMessage);
 assertType<string>(picker.value);
 assertType<string | null | undefined>(picker.name);
 assertType<string | undefined>(picker.min);

diff --git a/packages/field-base/src/field-mixin.d.ts b/packages/field-base/src/field-mixin.d.ts
@@ -33,11 +33,11 @@ export declare class FieldMixinClass {
   helperText: string | null | undefined;
 
   /**
-   * Error to show when the field is invalid.
+   * Error message to show when the field is invalid.
    *
    * @attr {string} error-message
    */
-  errorMessage: string;
+  errorMessage: string | null | undefined;
 
   protected readonly _ariaAttr: 'aria-labelledby' | 'aria-describedby';