fix: only run the crud grid header renderer once (#3386)

vaadin · Feb 3, 2022 · 158f36a · 158f36a
1 parent 2570682
commit 158f36a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/packages/crud/src/vaadin-crud-grid.js b/packages/crud/src/vaadin-crud-grid.js
@@ -167,6 +167,10 @@ class CrudGrid extends IncludedMixin(Grid) {
     if (!this.noHead && path) {
       // Create a header renderer for the column (or column group)
       col.headerRenderer = (root) => {
+        if (root.firstElementChild) {
+          return;
+        }
+
         const label = this._generateHeader(path);
 
         if (col.__sortColumnGroup || (this.noFilter && !this.noSort)) {

diff --git a/packages/crud/test/crud-grid.test.js b/packages/crud/test/crud-grid.test.js
@@ -194,6 +194,13 @@ describe('crud grid', () => {
         it('should capitalize correctly', () => {
           expect(grid.__capitalize('aa.bb cc-dd FF')).to.be.equal('Aa bb cc dd ff');
         });
+
+        it('should only render one control in a cell', async () => {
+          grid.requestContentUpdate();
+          await nextRender(grid);
+          expect(getHeaderCellContent(grid, 1, 0).childElementCount).to.equal(1);
+          expect(getHeaderCellContent(grid, 2, 0).childElementCount).to.equal(1);
+        });
       });
     });
   });