fix: revert setting align-self to stretch (#3534)

vaadin · Mar 10, 2022 · 189177b · 189177b
1 parent 3a73ac1
commit 189177b
Show file tree

Hide file tree

Showing 7 changed files with 0 additions and 53 deletions.
diff --git a/packages/menu-bar/src/vaadin-menu-bar.js b/packages/menu-bar/src/vaadin-menu-bar.js
@@ -65,7 +65,6 @@ class MenuBar extends ButtonsMixin(DisabledMixin(InteractionsMixin(ElementMixin(
       <style>
         :host {
           display: block;
-          align-self: stretch; /* make overflow work in flex */
         }
 
         :host([hidden]) {

diff --git a/packages/menu-bar/test/visual/lumo/menu-bar.test.js b/packages/menu-bar/test/visual/lumo/menu-bar.test.js
@@ -46,32 +46,6 @@ describe('menu-bar', () => {
         });
       });
 
-      describe('column flex', () => {
-        beforeEach(() => {
-          div = document.createElement('div');
-          div.style.display = 'flex';
-          div.style.padding = '10px';
-          div.style.maxWidth = '400px';
-          div.style.flexDirection = 'column';
-          div.style.alignItems = 'flex-start';
-
-          element = fixtureSync('<vaadin-menu-bar></vaadin-menu-bar>', div);
-          element.items = [
-            { text: 'Item 1' },
-            { text: 'Item 2' },
-            { text: 'Item 3' },
-            { text: 'Item 4' },
-            { text: 'Item 5' },
-            { text: 'Item 6' },
-            { text: 'Item 7' }
-          ];
-        });
-
-        it('flex-overflow', async () => {
-          await visualDiff(div, `${dir}-flex-overflow`);
-        });
-      });
-
       describe('theme', () => {
         function makeIcon(img) {
           const item = document.createElement('vaadin-context-menu-item');

diff --git a/...s/menu-bar/test/visual/lumo/screenshots/menu-bar/baseline/ltr-flex-overflow.png b/...s/menu-bar/test/visual/lumo/screenshots/menu-bar/baseline/ltr-flex-overflow.png
diff --git a/...s/menu-bar/test/visual/lumo/screenshots/menu-bar/baseline/rtl-flex-overflow.png b/...s/menu-bar/test/visual/lumo/screenshots/menu-bar/baseline/rtl-flex-overflow.png
diff --git a/packages/menu-bar/test/visual/material/menu-bar.test.js b/packages/menu-bar/test/visual/material/menu-bar.test.js
@@ -46,32 +46,6 @@ describe('menu-bar', () => {
         });
       });
 
-      describe('column flex', () => {
-        beforeEach(() => {
-          div = document.createElement('div');
-          div.style.display = 'flex';
-          div.style.padding = '10px';
-          div.style.maxWidth = '400px';
-          div.style.flexDirection = 'column';
-          div.style.alignItems = 'flex-start';
-
-          element = fixtureSync('<vaadin-menu-bar></vaadin-menu-bar>', div);
-          element.items = [
-            { text: 'Item 1' },
-            { text: 'Item 2' },
-            { text: 'Item 3' },
-            { text: 'Item 4' },
-            { text: 'Item 5' },
-            { text: 'Item 6' },
-            { text: 'Item 7' }
-          ];
-        });
-
-        it('flex-overflow', async () => {
-          await visualDiff(div, `${dir}-flex-overflow`);
-        });
-      });
-
       describe('theme', () => {
         function makeIcon(img) {
           const item = document.createElement('vaadin-context-menu-item');

diff --git a/...nu-bar/test/visual/material/screenshots/menu-bar/baseline/ltr-flex-overflow.png b/...nu-bar/test/visual/material/screenshots/menu-bar/baseline/ltr-flex-overflow.png
diff --git a/...nu-bar/test/visual/material/screenshots/menu-bar/baseline/rtl-flex-overflow.png b/...nu-bar/test/visual/material/screenshots/menu-bar/baseline/rtl-flex-overflow.png