Skip to content

Commit

Permalink
fix: update event types to use correct detail object (#3816) (#3817)
Browse files Browse the repository at this point in the history
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
  • Loading branch information
vaadin-bot and web-padawan committed May 10, 2022
1 parent 46607a1 commit b278188
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 18 deletions.
18 changes: 7 additions & 11 deletions packages/grid-pro/src/vaadin-grid-pro.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,23 +12,19 @@ export { GridProEditorType } from './vaadin-grid-pro-edit-column.js';
* Fired when the user starts editing a grid cell.
*/
export type GridProCellEditStartedEvent<TItem> = CustomEvent<{
value: {
index: number;
item: TItem;
path: string;
};
index: number;
item: TItem;
path: string;
}>;

/**
* Fired before exiting the cell edit mode, if the value has been changed.
*/
export type GridProItemPropertyChangedEvent<TItem> = CustomEvent<{
value: {
index: number;
item: TItem;
path: string;
value: string | boolean;
};
index: number;
item: TItem;
path: string;
value: string | boolean;
}>;

export interface GridProCustomEventMap<TItem> {
Expand Down
14 changes: 7 additions & 7 deletions packages/grid-pro/test/typings/grid-pro.types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,16 +32,16 @@ assertType<Grid<TestGridItem>>(narrowedGrid);
assertType<InlineEditingMixinClass>(narrowedGrid);

narrowedGrid.addEventListener('cell-edit-started', (event) => {
assertType<string>(event.detail.value.path);
assertType<number>(event.detail.value.index);
assertType<TestGridItem>(event.detail.value.item);
assertType<string>(event.detail.path);
assertType<number>(event.detail.index);
assertType<TestGridItem>(event.detail.item);
});

narrowedGrid.addEventListener('item-property-changed', (event) => {
assertType<string>(event.detail.value.path);
assertType<number>(event.detail.value.index);
assertType<TestGridItem>(event.detail.value.item);
assertType<string | boolean>(event.detail.value.value);
assertType<string>(event.detail.path);
assertType<number>(event.detail.index);
assertType<TestGridItem>(event.detail.item);
assertType<string | boolean>(event.detail.value);
});

narrowedGrid.addEventListener('active-item-changed', (event) => {
Expand Down

0 comments on commit b278188

Please sign in to comment.