Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[form-layout] updateStyles does not set CSS custom properties when custom-style is not imported #499

Closed
web-padawan opened this issue Mar 3, 2021 · 1 comment
Labels
bug Something isn't working no-polymer Removing Polymer from Vaadin public APIs vaadin-form-layout

Comments

@web-padawan
Copy link
Member

Two tests started to fail after I moved Lumo and Material to monorepo with removing custom-style:

packages/vaadin-form-layout/test/form-item.test.js:

 ❌ form-item > CSS properties > should apply label-width
      AssertionError: expected '112px' to equal '100px'
      + expected - actual
      
      -112px
      +100px
      
      at o.<anonymous> (packages/vaadin-form-layout/test/form-item.test.js:81:55)

 ❌ form-item > CSS properties > should apply label-spacing
      AssertionError: expected '16px' to equal '8px'
      + expected - actual
      
      -16px
      +8px
      
      at o.<anonymous> (packages/vaadin-form-layout/test/form-item.test.js:97:57)

https://github.com/vaadin/vaadin-web-components/runs/2020100700

When debugging, I noticed the custom CSS property is not set after calling updateStyles
form-bug

When adding import for custom-style, the tests are passing: e562d20

@vaadin-bot vaadin-bot transferred this issue from vaadin/vaadin-form-layout May 19, 2021
@vaadin-bot vaadin-bot added bug Something isn't working vaadin-form-layout labels May 19, 2021
@web-padawan web-padawan added the no-polymer Removing Polymer from Vaadin public APIs label May 19, 2021
@web-padawan web-padawan changed the title updateStyles does not set CSS custom properties when custom-style is not imported [form-layout] updateStyles does not set CSS custom properties when custom-style is not imported May 19, 2021
@web-padawan
Copy link
Member Author

The method and related tests were removed in Vaadin 24, see #4993. Closing.

@web-padawan web-padawan closed this as not planned Won't fix, can't repro, duplicate, stale Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working no-polymer Removing Polymer from Vaadin public APIs vaadin-form-layout
Projects
None yet
Development

No branches or pull requests

2 participants