Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[date-time-picker] Moving focus between the child pickers with the mouse results in early validation #5463

Open
vursen opened this issue Feb 6, 2023 · 0 comments

Comments

@vursen
Copy link
Contributor

vursen commented Feb 6, 2023

Description

Focusing a child picker with the mouse and subsequently focusing the opposite picker results in early validation, even though you are still interacting with the field.

I'd like to emphasize that using the mouse is key to reproducing the issue: early validation doesn't happen if you are moving focus inside the field with the keyboard.

Screen.Recording.2023-02-06.at.12.26.34.mov

Expected outcome

Regardless of the device you use to move focus (the keyboard or the mouse), there shouldn't be early validation. Otherwise, it may give you a wrong impression as if you've selected something wrong whereas it was simply a required check that failed because the field didn't have a value yet.

Minimal reproducible example

<script type="module">
  import '@vaadin/date-time-picker';
</script>

<vaadin-date-time-picker required></vaadin-date-time-picker>

Steps to reproduce

  1. Add the above example to an HTML page
  2. Click on the child date-picker
  3. Click on the child time-picker (will close the date-picker)

Environment

Vaadin version(s): 24.0 and earlier
OS: Mac OS

Browsers

Issue is not browser related

Additional context

Related to vaadin/platform#3066

@vursen vursen changed the title [DateTimePicker] Moving focus between sub-fields with the mouse results in early validation [date-time-picker] Moving focus between sub-fields with the mouse results in early validation Feb 6, 2023
@vursen vursen changed the title [date-time-picker] Moving focus between sub-fields with the mouse results in early validation [date-time-picker] Moving focus between the child pickers with the mouse results in early validation Feb 6, 2023
@yuriy-fix yuriy-fix added bug Something isn't working Impact: Low Severity: Minor labels Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants