Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item focus rings not rendered on touch devices #6381

Open
rolfsmeds opened this issue Aug 21, 2023 · 2 comments
Open

Item focus rings not rendered on touch devices #6381

rolfsmeds opened this issue Aug 21, 2023 · 2 comments

Comments

@rolfsmeds
Copy link
Contributor

rolfsmeds commented Aug 21, 2023

Description

Apparently the item focus ring in the dropdown in Select, ComboBox and DatePicker is not rendered on devices that present themselves as "non-hover" or "coarse pointer", for example touch screen devices (which can have keyboard focus e.g. via bluetooth keyboards).

https://drive.google.com/file/d/1rEmbmKzG43vnOiJyJ5GOyYE5X7nnx1qx/view?usp=sharing

Expected outcome

Focus rings should render whenever items are focused by keyboard, regardless of whether they have mouse-equivalent pointers.

Minimal reproducible example

https://vaadin.com/docs/latest/components/select

Steps to reproduce

Go to the above example, emulate a touch-screen device, and browse the items by keyboard.

Environment

Vaadin version(s): V24.2.alpha10
OS: any, I guess

Browsers

Any, I guess

@rolfsmeds rolfsmeds changed the title Value focus rings not rendered in Firefox on Windows Value focus rings not rendered on non-hover devices Aug 21, 2023
@rolfsmeds rolfsmeds added Impact: Low and removed regression Sometimes we make things break Impact: High labels Aug 21, 2023
@rolfsmeds
Copy link
Contributor Author

For Select and ComboBox, this is presumably caused by the following line in the vaadin-item Lumo stylesheet that restricts the focus ring to devices that match the any-hover:hover media query : https://github.com/vaadin/web-components/blob/main/packages/item/theme/lumo/vaadin-item-styles.js#L65-L74

For DatePicker, the culprit is probably this line in the vaadin-month-calendar Lumo stylesheet that hides the focus ring for devices that match the pointer:coarse media query : https://github.com/vaadin/web-components/blob/main/packages/date-picker/theme/lumo/vaadin-month-calendar-styles.js#L130-L143

@rolfsmeds rolfsmeds changed the title Value focus rings not rendered on non-hover devices Item focus rings not rendered on touch devices Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant