Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: align-self: stretch change is affecting horizontal flex #991

Open
web-padawan opened this issue Mar 6, 2019 · 0 comments
Open
Labels
documentation Improvements or additions to documentation vaadin-form-layout
Projects

Comments

@web-padawan
Copy link
Member

The change landed in vaadin/vaadin-form-layout#107 was targeting the form-layout placed in the element with flex-direction: column, but it was actually breaking change from the point of view of the users who try to center form-layout in the container setting flex-direction: row

This should have been released as 3.0.0 but we didn't do that. The proper way of handling this would be reverting change, releasing 2.1.3 and then putting that change back as 3.0.0

At the same time, we also have to document what form-layout is NOT supposed to be direct child of a flex layout (as it has to calculate its own width, and flex affects that)

@web-padawan web-padawan changed the title Ensure align-self: stretch change is Regression: align-self: stretch change is affecting horizontal flex Mar 6, 2019
@vaadin-bot vaadin-bot transferred this issue from vaadin/vaadin-form-layout May 19, 2021
@vaadin-bot vaadin-bot added documentation Improvements or additions to documentation vaadin-form-layout labels May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation vaadin-form-layout
Projects
No open projects
vaadin-core
  
📬  Inbox
Development

No branches or pull requests

2 participants