Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1: entity types and structure standardization #1650

Open
arkid15r opened this issue Jan 22, 2024 · 1 comment
Open

v1: entity types and structure standardization #1650

arkid15r opened this issue Jan 22, 2024 · 1 comment
Assignees
Labels

Comments

@arkid15r
Copy link
Collaborator

The current version has 2 main types of supported entities: country and financial. Not all entities of the country type can be countries per se. As ISO3166 defines a broader set of supported entities, e.g. names of countries, dependent territories, and special areas of geographical interest it'd be fair to rename accordingly, use iso3166 as a placeholder for iso3166 based entities. Keeping it as is for financial/market category can be a good idea.

The iso3166 entity files would be named according to their iso3166-1 codes.

Another point is the difference for specifying the code for country/market entities: using a standardized attribute name for both types would be more consistent. The difference could be provided based on class inheritance (separate base classes for iso3166 and financial entities) and/or entity_type field.

Questions and ideas are welcome!

@arkid15r arkid15r added the v1 label Jan 22, 2024
@arkid15r arkid15r self-assigned this Jan 22, 2024
@arkid15r
Copy link
Collaborator Author

This also should address concerns raised in #1063

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant